Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Traduccion faq/library#214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
humitos merged 30 commits intopython:3.8fromsdelquin:traduccion-faq/library
May 13, 2020
Merged

Conversation

sdelquin
Copy link
Contributor

No description provided.

Copy link
Collaborator

@humitoshumitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hola! Muchas gracias por la Pull Request. ¡Está super bien! 🎉

Hice algunas sugerencias y correciones. ¿Las puedes mirar y corregir? Gracias!

@humitoshumitos self-requested a reviewMay 10, 2020 16:58
@humitoshumitos mentioned this pull requestMay 10, 2020
@humitos
Copy link
Collaborator

@sdelquin este PR está bien para mí --solo quedaría arreglar el Travis que no parece ser un gran problema. ¿Puedes hacerlo?

sdelquin reacted with thumbs up emoji

@humitos
Copy link
Collaborator

@sdelquin hrm... parece que des-hiciste mis cambios en tus últimos dos commits. ¿Puedes revisarlo?

Copy link
Collaborator

@humitoshumitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Perfecto! Lo que sigue de "excelente"! Muchas gracias! 😄

sdelquin reacted with heart emoji
@humitoshumitos merged commitb2ec573 intopython:3.8May 13, 2020
@sdelquin
Copy link
ContributorAuthor

Un placer@humitos y@marian-vignau. Gracias por el trabajo que están haciendo. Han sido los primeros revisores de código que he tenido nunca jaja Una bonita experiencia.

humitos reacted with heart emoji

@humitoshumitos mentioned this pull requestMay 22, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@humitoshumitoshumitos approved these changes

@marian-vignaumarian-vignaumarian-vignau left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@sdelquin@humitos@marian-vignau
[8]ページ先頭
©2009-2025 Movatter.jp