- Notifications
You must be signed in to change notification settings - Fork397
omitir warnings de 'availability' y 'wasm-notavail'#1847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Uh oh!
There was an error while loading.Please reload this page.
raulcd approved these changesOct 26, 2022
Gracias por el review@raulcd 💯 |
Mencionando#1845 para que esté enlazado ese issue con este pr |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
edit: including explanation
the whole story on the 'availability' warnings are that there is a
.. availability::
command in the cpython docs that include, in some cases, stuff from the 'wasm-availability' file. So we have references "within" the 'availabiliy' command.as you can see, the entry has no mention of WASM or wahtsover in some entries, like "Unix, Windows",
but still will generate the following warning:
The reason that due to the internal reference to 'wasm-availability' , even in cases like this entry, where it's only Unix and Windows, for example:
https://docs.python.org/3.11/library/os.html?highlight=os#os.getenv
it generates the reference to the 'Availability' page, which inside has the 'wasm-availability' inside:
https://docs.python.org/3.11/library/intro.html#availability
Additionally, the
wasm-notavail
file is excluded to avoid the warning related to the file not being inclued in any index. We could have add:orphan:
to the file insidecpython
but we do it via the exclude patterns to avoid touching files on the submodule.