- Notifications
You must be signed in to change notification settings - Fork396
Omitir directorio .overrides/logo para ln y mejoras#1840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Changes from1 commit
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
- Se omite el directorio logo, para que `ln` no genere warnings.- Se cambian algunas cosas en el archivo `conf.py` para solucionar algunos warnings de flake8
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -13,21 +13,28 @@ | ||||||
| # | ||||||
| # $ sphinx-build -b html -d _build/doctrees -D language=es . _build/html | ||||||
| import sys | ||||||
| import os | ||||||
| import time | ||||||
| sys.path.append(os.path.abspath('cpython/Doc/tools/extensions')) | ||||||
| sys.path.append(os.path.abspath('cpython/Doc/includes')) | ||||||
| # Import all the Sphinx settings from cpython | ||||||
| # This import will trigger warnings on the 'Include/patchlevel.h' | ||||||
| # not being found, because it execute the content of the whole file, | ||||||
| # and there there is a local call to 'get_header_version' like the one | ||||||
| # we have in a few lines. | ||||||
| sys.path.insert(0, os.path.abspath('cpython/Doc')) | ||||||
| from conf import * | ||||||
| # Call patchlevel with the proper path to get the version from | ||||||
| # instead of hardcoding it | ||||||
| from patchlevel import get_header_version_info | ||||||
| version, release = get_header_version_info(os.path.abspath('cpython/Doc')) | ||||||
| project = 'Python en Español' | ||||||
| year = time.strftime("%Y") | ||||||
| copyright = f'2001-{year}, Python Software Foundation' | ||||||
| html_theme_path = ['cpython/Doc/tools'] | ||||||
| templates_path = ['cpython/Doc/tools/templates'] | ||||||
| @@ -61,14 +68,18 @@ | ||||||
| extensions = _extensions | ||||||
| if os.environ.get('SPHINX_GETTEXT')is None: | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Me imagino que está explícito, por si tiene un valor, cual sea. Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Era para hacerlo explícito la verdad, a pesar que tenemos cosas tan raras como: >>>notNoneTrue era para dejar en claro que quería mirar si El problema con usar >>>importos>>>r=os.environ.get("LALA")>>>r>>>risNoneTrue>>>%exportLALA=""%exportLELE=0%python>>>importos>>>os.environ.get("LALA")''>>>os.environ.get("LELE")'0'>>>notos.environ.get("LALA")True>>>notos.environ.get("LELE")False>>>notos.environ.get("ALGO_QUE_NO_EXISTE")True pero para términos de este script, dudo que en algún momento alguien defina la variable a algo más :P pero es la costumbre de estar preparado para todo jaja There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Está bien chistoso porque justo el | ||||||
| # Override all the files from ``.overrides`` directory | ||||||
| from pathlib import Path | ||||||
| overrides_paths = Path('.overrides') | ||||||
| for path in overrides_paths.glob('**/*.*'): | ||||||
| if path.name == 'README.rst' and path.parent == '.overrides': | ||||||
| continue | ||||||
| # Skip the files in the .overrides/logo directory | ||||||
| # to avoid ln issues. | ||||||
| if str(path.parent).endswith("logo"): | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Creen que valga la pena colocar este if y el anterior como filtros, y sacar la acción del There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. como estaban motivadas por cosas distintas, preferí dejarlo separado, mal que mal, lo del logo es bastante nuevo. No sé si ganemos muchos con el tema de la función, total el archivo | ||||||
| continue | ||||||
| destroot = str(path.parent).replace('.overrides', '').lstrip('/') | ||||||
| outputdir = Path('cpython/Doc') / destroot / path.name | ||||||
| os.system(f'ln -nfs `pwd`/{path.parent}/{path.name} {outputdir}') | ||||||
| @@ -85,6 +96,7 @@ | ||||||
| _stdauthor, 'manual'), | ||||||
| ] | ||||||
| def setup(app): | ||||||
| def add_contributing_banner(app, doctree): | ||||||
| @@ -101,10 +113,13 @@ def add_contributing_banner(app, doctree): | ||||||
| return | ||||||
| from docutils import nodes, core | ||||||
| from textwrap import dedent | ||||||
| message = dedent(f"""\ | ||||||
| ¡Ayúdanos a traducir la documentación oficial de Python al Español! | ||||||
| Puedes encontrar más información en `Como contribuir </es/{version}/CONTRIBUTING.html>`_. | ||||||
| Ayuda a acercar Python a más personas de habla hispana. | ||||||
| """) | ||||||
| paragraph = core.publish_doctree(message)[0] | ||||||
| banner = nodes.warning(ids=['contributing-banner']) | ||||||