- Notifications
You must be signed in to change notification settings - Fork396
Chequea orden en TRANSLATORS#1830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
El ordenamiento se hace usando el colaje de cadenas de texto del localeactual, y sobre stdin, haciendo la herramienta lo más flexible posible.Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
eb57138 to3f2372bCompareCuando nueva gente se agregue a sí misma a la lista de autores enTRANSLATORS, este nuevo paso en GitHub actions corroborará que elarchivo TRANSLATORS sigue estando ordenado alfabéticamente, y generaráun error de no ser éste el caso.Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
cmaureir approved these changesJul 10, 2022
Super buena idea :D gracias 🎉 |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dado que el archivo
TRANSLATORSfue ordenado alfabéticamente, sería bueno mantener ese orden en el futuro.Este PR agrega un paso en el GitHub actions para chequear que el archivo sigue estando ordenado alfabéticamente, y genera un error de no ser así. El chequeo se hace comparando el archivo sin modificar contra la salida de un nuevo script
scripts/sort.py, el cual lee el archivo, ordena las entradas alfabéticamente, e imprime el resultado. Si el resultado es igual al contenido del archivo entonces el archivo está ya ordenado.El script es genérico, por lo que puede ser usado en el futuro para otras tareas similares.