- Notifications
You must be signed in to change notification settings - Fork396
Mueve dict -> dictionaries/_base.txt#1651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes fromall commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Mueve dict -> dictionaries/_base.txt
El archivo "dict" anteriormente era el único archivo donde se guardabanlas palabras para usar con el chequeador de ortografía, Actualmenteusamos la técnica de tener un archivo por módulo dentro delubdirectorio diccionaries/ donde se agregan las palabras de formaindividual al módulo que corresponde. Al momento de chequear laortografía del proyecto entero, se mergean todos los diccionarios en unosolo llamado "dict.txt", el cual existe efímeramente, y que no tiene queser editado.La existencia de dos archivos "dict" y "dict.txt" es confusa, y más aúncuando hay además un subdirectorio con más diccionarios dentro. Paramejorar esta situación, este commit mueve "dict" adiccionaries/_base.txt. El nunevo nombre sirve dos propósitos: laextensión .txt asegura que el diccionario va a ser parte del proceso demergeo de diccionarios; y segundo, el prefijo "_" lo hace ver como unarchivo especial que se diferencia claramente del resto.Finalmente, también aproveché de sacar el target dict_dups del Makefile,el cual no tenía sentido mantener.Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit28e2c42f991482aeca4377a3bad2b3e81e70a027
There are no files selected for viewing
14 changes: 0 additions & 14 deletionsMakefile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -96,17 +96,3 @@ spell: venv | ||
.PHONY: wrap | ||
wrap: venv | ||
$(VENV)/bin/powrap **/*.po | ||
File renamed without changes.
4 changes: 0 additions & 4 deletionsscripts/create_dict.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.