Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Translate file library/collections.abc.po#580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@mgiannopoulos24
Copy link
Contributor

@mgiannopoulos24mgiannopoulos24 commentedJan 3, 2025•
edited
Loading

Ποιο issue κλείνει το συγκεκριμένο PR;

Closes#471

Περιγραφή του PR

Προστέθηκε η μετάφραση τουcollections.abc.po.

Λίστα Εργασιών

  • Προσθήκη λέξεων στο ευρετήριοmain.txt.

@mgiannopoulos24mgiannopoulos24 requested a review froma team as acode ownerJanuary 3, 2025 16:32
Copy link
Collaborator

@skpanagiotisskpanagiotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Καλή δουλειά, λίγο δύσκολο κείμενο με αρκετούς όρους δύσκουλους στη μετάφραση. Έχω κάνει κάποια suggestions. Μια παρατήρηση είναι η μετάφραση της λέξης co-routine.

mgiannopoulos24and others added12 commitsJanuary 8, 2025 16:56
Co-authored-by: Panagiotis Skias <panagiotis.skias@gmail.com>
Co-authored-by: Panagiotis Skias <panagiotis.skias@gmail.com>
Co-authored-by: Panagiotis Skias <panagiotis.skias@gmail.com>
Co-authored-by: Panagiotis Skias <panagiotis.skias@gmail.com>
Co-authored-by: Panagiotis Skias <panagiotis.skias@gmail.com>
Co-authored-by: Panagiotis Skias <panagiotis.skias@gmail.com>
Co-authored-by: Panagiotis Skias <panagiotis.skias@gmail.com>
Co-authored-by: Panagiotis Skias <panagiotis.skias@gmail.com>
Co-authored-by: Panagiotis Skias <panagiotis.skias@gmail.com>
Co-authored-by: Panagiotis Skias <panagiotis.skias@gmail.com>
Co-authored-by: Panagiotis Skias <panagiotis.skias@gmail.com>
@mgiannopoulos24
Copy link
ContributorAuthor

Να αλλάξω όλα τα co routines σε συρρουτίνες;

@skpanagiotis
Copy link
Collaborator

Προσωπικά, δεν μου κολλάει και τόσο το συρρουτίνες. Επειδή ο όρος routine και συνεπώς coroutine είναι όροι της Python θα έλεγα μήπως το αφήναμε έτσι.

@mgiannopoulos24
Copy link
ContributorAuthor

Εντάξει θα τα αφήσω όλα coroutines.

Copy link
Collaborator

@skpanagiotisskpanagiotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Κάποια κενά που έχουν ξεφύγει. Κατά τα άλλα lgtm.

mgiannopoulos24and others added4 commitsJanuary 11, 2025 00:16
Co-authored-by: Panagiotis Skias <panagiotis.skias@gmail.com>
Co-authored-by: Panagiotis Skias <panagiotis.skias@gmail.com>
Co-authored-by: Panagiotis Skias <panagiotis.skias@gmail.com>
Co-authored-by: Panagiotis Skias <panagiotis.skias@gmail.com>
@mgiannopoulos24
Copy link
ContributorAuthor

Νόμιζα ότι τοpowrap τα κόβει, αλλά μάλλον όχι.

@skpanagiotis
Copy link
Collaborator

skpanagiotis commentedJan 15, 2025•
edited
Loading

Θα το κάνω άλλο ένα review, αν και θα ήθελα να το κάνεις και κάποιος άλλο, και θα γίνει approve για να κλείσει. Πάντως μπράβο δύσκολο αρχείο 🎉

mgiannopoulos24 reacted with heart emoji

Copy link
Collaborator

@gmargaritisgmargaritis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Πολύ καλή δουλεία 🤘

Αφήνω μερικές προτάσεις, LGTM overall!

mgiannopoulos24and others added4 commitsJanuary 15, 2025 16:26
Co-authored-by: George Margaritis <gmargaritis@protonmail.com>
Co-authored-by: George Margaritis <gmargaritis@protonmail.com>
Co-authored-by: George Margaritis <gmargaritis@protonmail.com>
mgiannopoulos24and others added4 commitsJanuary 15, 2025 17:23
Co-authored-by: George Margaritis <gmargaritis@protonmail.com>
Co-authored-by: Panagiotis Skias <panagiotis.skias@gmail.com>
@skpanagiotis
Copy link
Collaborator

Προτείνω να γίνει merge το συγκεκριμένο PR.

@mgiannopoulos24
Copy link
ContributorAuthor

@skpanagiotis δεν έχω κάνει resolve όλες τις αλλαγές που θέλετε. Δεν ξέρω αν τελικά θέλετε να τα αφήσωmutable ή να τα αλλάξω σεμεταβλητά. Πείτε μου αυτό μόνο για να τα κάνω resolve.

Copy link
Collaborator

@gmargaritisgmargaritis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM 🍰

skpanagiotis reacted with heart emoji
@skpanagiotisskpanagiotis merged commitb413765 intopython:3.12Jan 20, 2025
2 checks passed
@mgiannopoulos24mgiannopoulos24 deleted the translate/library-collections-abc branchJanuary 22, 2025 12:27
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@gmargaritisgmargaritisgmargaritis approved these changes

@skpanagiotisskpanagiotisskpanagiotis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[3.12] Translatelibrary/collections.abc.po

3 participants

@mgiannopoulos24@skpanagiotis@gmargaritis
[8]ページ先頭
©2009-2025 Movatter.jp