Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Enable decimal_pi benchmark in the suite (MANIFEST)#453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
skirpichev wants to merge3 commits intopython:main
base:main
Choose a base branch
Loading
fromskirpichev:enable-decimal_pi

Conversation

@skirpichev
Copy link
Member

They were not added here in#341 for no reasons.

They were not added here inpython#341 for no reasons.
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@hugovk
Copy link
Member

hugovk commentedJan 19, 2026
edited
Loading

cc@mdboom in case there was a reason to omit them.

@skirpichev
Copy link
MemberAuthor

Ah, pypy3 failure seems relevant. decimal_factorial looks too slow on PyPy3 (with only pure-Python version of the decimal module).

@hugovkhugovk changed the titleEnable decimal benchmarks in the suite (MANIFEST)Enable decimal_pi benchmark in the suite (MANIFEST)Jan 20, 2026
@skirpichev
Copy link
MemberAuthor

@hugovk, anything else?

I think we can enable decimal_factorial test, but this will need a workaround for pure-Python decimal module. The presence of accelerated module we can detect, trying to import the_decimal module.

  1. Either we can lowern andc.prec (we can't use MAX_PREC for pure-Python module) inbench_decimal_factorial()
  2. or use different settings conditionally, for pure-Python and C modules

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@hugovkhugovkhugovk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@skirpichev@hugovk

[8]ページ先頭

©2009-2026 Movatter.jp