Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork201
Add option for rigorous in benchmark.conf.sample#446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
corona10 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
lgtm!
The test failure does not looks like reated to this PR.
But need to check
pyperformance/pyperformance/tests/test_commands.py
Lines 147 to 167 in0ffe825
| deftest_run_and_show(self): | |
| filename=self.resolve_tmp("bench.json") | |
| # -b all: check that *all* benchmark work | |
| # | |
| # --debug-single-value: benchmark results don't matter, we only | |
| # check that running benchmarks don't fail. | |
| # XXX Capture and check the output. | |
| self.run_pyperformance( | |
| "run", | |
| "-b", | |
| "all", | |
| "--debug-single-value", | |
| "-o", | |
| filename, | |
| capture=None, | |
| ) | |
| # Display slowest benchmarks | |
| # XXX Capture and check the output. | |
| self.run_module("pyperf","slowest",filename) |
4494463 intomainUh oh!
There was an error while loading.Please reload this page.
* main: Bump mypy from 1.19 to 1.19.1 (python#448) Add a YAML-parsing benchmark (python#342) Add FastAPI HTTP request benchmark (python#440) Add option for rigorous in benchmark.conf.sample (python#446) Do not `venv.ensure_reqs` twice (python#432) Bump mypy from 1.18.2 to 1.19.0 (python#442) Bump actions/checkout from 5 to 6 in the actions group (python#441) Add example scripts to run pyperformance on a generic host (python#436) Prepare for 1.13.0 release (python#435) Reenable xdsl (python#433) Bump actions/setup-python from 5 to 6 (python#429) Group Dependabot updates for GitHub Actions into single PR (python#431) Bump actions/checkout from 4 to 5 (python#430)
Closes#445
No tests because there are no current tests for the option configurations in the current file :(.
I have manually verified that it works on my system.