Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork201
Add benchmarks for the decimal module#341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
These currently exist in the [CPython source](https://github.com/python/cpython/blob/main/Modules/_decimal/tests/bench.py),but it would be good to have them here for continuous benchmarking.
ericsnowcurrently left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
Were you planning on adding the new benchmarks to the suite (i.e. pyperformance/data-files/benchmarks/MANIFEST)? At least you could add them there and leave them commented out. Is there any reason leave them out though?
They were not added here inpython#341 for no reasons.
These currently exist in theCPython source, but it would be good to have them here for continuous benchmarking.