Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add a benchmark based onpython -m pprint#222

Merged
ericsnowcurrently merged 9 commits intopython:mainfrom
arhadthedev:pprint
Jul 7, 2022
Merged

Add a benchmark based onpython -m pprint#222
ericsnowcurrently merged 9 commits intopython:mainfrom
arhadthedev:pprint

Conversation

@arhadthedev
Copy link
Member

  1. The moved code measures performance so it should belong here.
  2. The relocation lifts off a questionwhetherpython -m pprint should have tests or not.

After merging,python/cpython#92546 needs to be closed.

@arhadthedev
Copy link
MemberAuthor

This creative PR is a receiving half ofpython/cpython#94613.

@ericsnowcurrentlyericsnowcurrently changed the titleMove a benchmark frompython -m pprintAdd a benchmark based onpython -m pprintJul 7, 2022
Copy link
Member

@ericsnowcurrentlyericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for working on this, Oleg! I've left some comments for you to consider.

arhadthedev reacted with heart emoji
@arhadthedev
Copy link
MemberAuthor

@ericsnowcurrently Thank you for your thorough feedback, I've addressed everything.

In addition, I've also moved a class docstring into a file comment, and reworded it together with authorship. I hope I've made it right.

Also I've addedhasattr-based conditional running of_safe_repr to not fail CI for pre-3.10 CPython.

What did you have in mind relative to stdlib benchmarks? Note that we already have a bunch of micro-benchmarks for various parts of the stdlib, in distinct benchmarks.

Initially I've thought that a benchmark should be big, likeLib/test/*.py test files.

Copy link
Member

@ericsnowcurrentlyericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the updates.

@ericsnowcurrentlyericsnowcurrently merged commit684eafe intopython:mainJul 7, 2022
@arhadthedevarhadthedev deleted the pprint branchJuly 8, 2022 03:12
miss-islington pushed a commit to python/cpython that referenced this pull requestJul 25, 2022
This PR couples withpython/pyperformance#222 and supersedes#92560. Inspired by#93096 (comment).Automerge-Triggered-By: GH:ericsnowcurrently
@donbarbosdonbarbos mentioned this pull requestMar 12, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ericsnowcurrentlyericsnowcurrentlyericsnowcurrently approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arhadthedev@ericsnowcurrently

Comments

[8]ページ先頭
©2009-2026 Movatter.jp