Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add energy measurements support#140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
cappadokes wants to merge6 commits intopython:main
base:main
Choose a base branch
Loading
fromcappadokes:main

Conversation

cappadokes
Copy link
Contributor

@cappadokescappadokes commentedFeb 24, 2022•
edited
Loading

This PR introduces a new,--track-energy option for reporting energy consumption measurements instead of execution time, memory etc.

ATTENTION:--track-energy needschanges in pyperf in order to work, sincepyperf is thereal place where benchmarks are run.

Copy link
Member

@gvanrossumgvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This PR's title doesn't match what the code does (it seems to be adding a--track-energy flag).

@@ -10,7 +10,7 @@ psutil==5.8.0
# via -r requirements.in
pyparsing==3.0.6
# via packaging
pyperf==2.3.0
pyperf @ file:///home/cappadokes/code/pyperf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This seems like something you changed locally, but that should be changed back before landing this.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Unfortunately this is somewhat tricky:

  • for--track-energy to work,pyperf should also support energy measurements. There is no suchpyperf release at the moment, butwe are working on it.
  • until then, if a user wants to use--track-energy frompyperformance, she must indeed use a localpyperf inrequirements.txt.

@cappadokes
Copy link
ContributorAuthor

This PR's title doesn't match what the code does (it seems to be adding a--track-energy flag).

To be precise, the code both fixes the--inherit-environ issue and it also adds a--track-energy flag. I apologize for not splitting this in 2 separate PRs, but the changes under discussion are partly interdependent (--track-energy needs--inherit-environ to work, though the converse does not hold).

I will soon follow up with a documentation commit for clarification. I will also change the PR's name so as to contain both points.

@cappadokescappadokes changed the titleFix --inherit-environ issueFix --inherit-environ issue, Add energy measurements supportMar 17, 2022
@ericsnowcurrently
Copy link
Member

@cappadokes, please put the--track-energy addition in a separate PR. We will merge the fix for--inherit-environ first.

@cappadokescappadokes changed the titleFix --inherit-environ issue, Add energy measurements supportAdd energy measurements supportApr 27, 2022
@cappadokes
Copy link
ContributorAuthor

@cappadokes, please put the--track-energy addition in a separate PR. We will merge the fix for--inherit-environ first.

@ericsnowcurrently done.--inherit-environ ishere now.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@gvanrossumgvanrossumgvanrossum left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@cappadokes@ericsnowcurrently@gvanrossum
[8]ページ先頭
©2009-2025 Movatter.jp