python/pyperformancePublic

NotificationsYou must be signed in to change notification settings
Fork187
Star912

Add simple memory allocation benchmark#132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

tiran wants to merge5 commits intopython:main

base:main

Choose a base branch

fromtiran:bm_alloc

Open

Add simple memory allocation benchmark#132

tiran wants to merge5 commits intopython:mainfromtiran:bm_alloc

Conversation

Copy link

Member

tiran commentedFeb 8, 2022

No description provided.

Add simple memory allocation benchmark

7ce4e79

pablogsal reviewed

Feb 8, 2022

View reviewed changes

pyperformance/data-files/benchmarks/bm_alloc/run_benchmark.py OutdatedShow resolvedHide resolved

pablogsal reviewed

Feb 8, 2022

View reviewed changes

pyperformance/data-files/benchmarks/bm_alloc/run_benchmark.pyShow resolvedHide resolved

tiran added2 commits

February 8, 2022 15:59

Use smaller sizes to stress obmalloc

633ece4

Update docs

2554bae

Copy link

Member

pablogsal commentedFeb 8, 2022

I'm happy landing this. Let's give some days if@vstinner wants to take a look.

pablogsal reviewed

Feb 8, 2022

View reviewed changes

pyperformance/data-files/benchmarks/bm_alloc/run_benchmark.py OutdatedShow resolvedHide resolved

Update pyperformance/data-files/benchmarks/bm_alloc/run_benchmark.py

64e87e5

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>

Copy link

Member

vstinner commentedFeb 8, 2022

Does it belong to pyperformance which is supposed to be a set of "macro benchmarks"?

IMO it's to have benchmarks outside pyperformance.@ericsnowcurrently wants to add the ability to plug your own benchmark suite in pyperformance using configuration files, but I didn't follow his PR recently.

Copy link

Member

pablogsal commentedFeb 8, 2022

Does it belong to pyperformance which is supposed to be a set of "macro benchmarks"?

I would say yes: we have things that are quite small in what they do anyway. C'mon, we even have unpacking tests:

pyperformance/pyperformance/data-files/benchmarks/bm_unpack_sequence/run_benchmark.py

Lines 10 to 20 in034f58b

	for_inrange_it:
	# 400 unpackings
	a,b,c,d,e,f,g,h,i,j=to_unpack
	a,b,c,d,e,f,g,h,i,j=to_unpack
	a,b,c,d,e,f,g,h,i,j=to_unpack
	a,b,c,d,e,f,g,h,i,j=to_unpack
	a,b,c,d,e,f,g,h,i,j=to_unpack
	a,b,c,d,e,f,g,h,i,j=to_unpack
	a,b,c,d,e,f,g,h,i,j=to_unpack
	a,b,c,d,e,f,g,h,i,j=to_unpack
	a,b,c,d,e,f,g,h,i,j=to_unpack

Copy link

Member

vstinner commentedFeb 8, 2022

C'mon, we even have unpacking tests:

Maybe these tests don't belong to pyperformance :-(

I would say yes: we have things that are quite small in what they do anyway.

It's up to you.

Copy link

Member

ericsnowcurrently commentedFeb 8, 2022

Does it belong to pyperformance which is supposed to be a set of "macro benchmarks"?
@ericsnowcurrently wants to add the ability to plug your own benchmark suite in pyperformance

My PR landed a while back and is part of the most recent release.

That said, we already have a bunch of micro benchmarks so I'm not opposed to adding more. (We can separate the bunch later.) However, it would be worth marking them as "micro" sooner rather than later so they are easy to skip. That would involve adding/updatingtags = "micro" in the[tool.pyperformance] section of each benchmark's pyproject.toml. For this PR it would probably be okay to do so just for the new benchmark.