Movatterモバイル変換

Support relative home in pyvenv.cfg (host-relocatable venv)python/cpython#136051

Open

StanFromIreland reviewed

.github/CODEOWNERS OutdatedShow resolvedHide resolved

Copy link

Member

hugovk commentedJun 30, 2025

Hello, before we go any further with this PR, has the idea been discussed on Discourse?

And after that we'll need a sponsor before assigning the PEP number, do you have one yet? Let's unassign 796 for now.

Please see:

hugovk added the DO-NOT-MERGE label

hugovk changed the title~~PEP 796: relative virtual environments, initial draft~~PEP xxx: relative virtual environments, initial draft

Yes:https://discuss.python.org/t/making-venvs-relocatable-friendly/96177

revert codeowners change

175f378

Copy link

Author

rickeylev commentedJun 30, 2025

Thanks@hugovk and@StanFromIreland for the early review. I used a draft PR to see the CI results to further clean it up -- my apologies for wasting some of your time, but thank you regardless.

discussed on Discourse?

The criteria of "discussed enough with enough support" is vague, but what gave me enough confidence to begin a PEP and start a (draft) PR at this point was:

The thread didn't go totally off the rails (i.e. voracious disapproval)
Positive statements from@ncoghlan inhttps://discuss.python.org/t/making-venvs-relocatable-friendly/96177/21 andgh-135773: have pyvenv.cfg without home key anchor a venv and deduce home cpython#135831 (comment)

Sponsor needed to assign number

Thanks for clarifying that part! Yes, finding a sponsor is my next big step.

Copy link

Member

hugovk commentedJun 30, 2025

I used a draft PR to see the CI results to further clean it up

Tip: you can enable GitHub Actions athttps://github.com/rickeylev/peps/actions and run the CI on your fork.

Yes, finding a sponsor is my next big step.

Good luck!

rickeylev added6 commits

July 1, 2025 18:17

remove packaging-related specs

31cb756

fix lint errors with headers

cd46f4d

set sponsor

b532f5c

set sponsor as codeowner

99434fc

clarify title to focus on core pyvenv.cfg home behavior

862142a

fix typo; remove host-relocatable mention; remove non-germane copying…

1c8fb2d

…-venv section

zanieb reviewed

Jul 6, 2025

peps/pep-0796.rst OutdatedShow resolvedHide resolved

hugovk reviewed

Jul 11, 2025

feat(core): switch to script bootstrap as a defaultbazel-contrib/rules_python#3117

peps/pep-0796.rst OutdatedShow resolvedHide resolved

aignas mentioned this pull request

Jul 24, 2025

Open

1 task

Vigilans mentioned this pull request

Jul 28, 2025

Support copy or hardlink python interpreter when creating venvastral-sh/uv#6782

Open

This comment has been minimized.

Copy link

Member

AA-Turner commentedAug 6, 2025

@paveldikov thank you for the comment, please could you re-post it on Discourse? The peps repo / PR discussion is mainly for editorial discussion, rather than substantive comment on the proposal itself.

rickeylevand others added4 commits

August 17, 2025 13:02

Apply suggestions from code review

5b259cc

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>Co-authored-by: Zanie Blue <contact@zanie.dev>

Merge branch 'main' ofhttps://github.com/python/pepsinto relative.v…

560dadb

…envs

Merge branch 'relative.venvs' ofhttps://github.com/rickeylev/pepsin…

f41ed51

…to relative.venvs

better answer why/how relvenvs help; wrap some long lines

5cbc9f5

rickeylev commented

Aug 17, 2025

Copy link

Author

rickeylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the reviews! I'm out from under $dayJob and vacation backlogs a bit now and addressed comments.

peps/pep-0796.rst OutdatedShow resolvedHide resolved

StanFromIreland reviewed

Copy link

Member

StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Some little notes

peps/pep-0796.rst OutdatedShow resolvedHide resolved

ncoghlan removed the DO-NOT-MERGE label

Copy link

Contributor

ncoghlan commentedAug 18, 2025

Belatedly removed the DO-NOT-MERGE label (that was added pending the Discourse discussion and sponsorship of the PEP)

AA-Turner requested changes

Copy link

Member

AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The PEP is currently missing aSecurity Implications section, which I think should be added given that arbitrary directory traversal is permitted -- at the very least explaining why this is fine.

Several editorial notes, I think the Motivation & Rationale sections should be strengthened to focus on the benefits from relative environments, there is currently (I believe) a lot of assumed context.

The PEP also discusses at some length a broader proposal for reloacatable venvs. Is it worth considering making that the proposal here? I don't know the specifics, so it might be that the changes needed for 'relocatable' are too large to tackle in one go.

peps/pep-0796.rst OutdatedShow resolvedHide resolved

AA-Turner changed the title~~PEP 796: relative virtual environments, initial draft~~PEP 796: Relative Virtual Environments [initial draft]

rickeylevand others added2 commits

August 20, 2025 22:12

Apply AA-Turner suggestions

0af0eea

Co-authored-by: Alyssa Coghlan <ncoghlan@gmail.com>Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

add refs, remove CWD acronym, fix grammar

68dd5e0

rickeylev commented

Aug 21, 2025

Copy link

Author

rickeylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Applied suggestions and addressed a few comments; didn't have time to address everything, though.

peps/pep-0796.rst OutdatedShow resolvedHide resolved

address review comments: better split and organize rationale/motivation

b50a80c

rickeylev commented

Aug 24, 2025

Implement venv support for bootstrap system_pythonbazel-contrib/rules_python#3245

Copy link

Author

rickeylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ok, all pending comments addressed (I think. The Github UI frequently tricks me 😂 )

PTAL

re: security section: added. At least, insofar as I understand your concern correctly.

re: motivation and rationale strengthening: Thanks! Yeah, honestly, a big issue I've had writing this that "Motivation" and "Rationale" are, to me at least, practically synonyms. I did my best to better separate "Why do this change at all?" (motivation) and "Implementation decision and why that decision" (rationale).

re: proposing relocatable venv in this pep: I added a section about why this pep limits its scope to just the core interpreter.

peps/pep-0796.rst OutdatedShow resolvedHide resolved

rickeylev mentioned this pull request

Sep 6, 2025

Open

AA-Turner added the new-pepA new draft PEP submitted for initial review label

Sep 29, 2025

Merge branch 'main' into relative.venvs

af8f880

ncoghlan approved these changes

Copy link

Contributor

ncoghlan left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

A few editorial comments inline, but I think this is essentially ready for publication.

peps/pep-0796.rst OutdatedShow resolvedHide resolved

peps/pep-0796.rst

		During interpreter startup (i.e.:file:`getpath.py`), the relative path is joined to the
		directory containing ``pyvenv.cfg`` to form an absolute path.
		Parent-directory references (``../``) and current
		directory references (``./``) are resolved syntactically (i.e. not resolving

Copy link

Contributor

ncoghlanSep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	directory references (``./``) are resolvedsyntactically (i.e. not resolving
	directory references (``./``) are resolvedlexically (i.e. not resolving

(I don't mind if this isn't accepted, I've just always referred to this style of resolution as lexical rather than as syntactic:python/cpython#124825

peps/pep-0796.rst OutdatedShow resolvedHide resolved

peps/pep-0796.rst


		This PEP does not specify how to create a ``pyvenv.cfg`` with a relative path,
		nor how downstream tools (e.g. installers) should identify them or process
		them. These questions are best addressed separately by tool owners.

Copy link

Contributor

ncoghlanSep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This isn't an open issue, but rather than intentional omission. Perhaps just include a variant of this paragraph in the rationale subsection about not fully specifying portable virtual environments?

hugovk changed the title~~PEP 796: Relative Virtual Environments [initial draft]~~PEP 796: Relative Virtual Environments

hugovk reviewed

https://peps.python.org/pep-0012/#general

peps/pep-0796.rst OutdatedShow resolvedHide resolved

peps/pep-0796.rst Outdated

		machines do so either by relying on undocumented interpreter behaviour
		(Bazel, omitting the ``home`` key entirely to trigger an implementation
		dependent fallback to resolving via a symlinked interpreter binary on
		non-Windows systems, see `gh-135773`) or by requiring a post-installation script to be executed

Copy link

Member

hugovkSep 30, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

~~Lint fix:~~

Alyssa's suggestion below is better.

peps/pep-0796.rst OutdatedShow resolvedHide resolved

peps/pep-0796.rst

Comment on lines +210 to +216

		How to Teach This
		=================

		Teaching this should be straightforward: if you use a relative path in
		``pyvenv.cfg``, then it's relative to the directory containing the
		``pyvenv.cfg`` file. This is simple to explain and easy to understand for
		anyone that is already familiar with handling relative filesystem paths.

Copy link

Member

hugovkSep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It might be useful to saywhere you will teach this. What docs will you update?

peps/pep-0796.rst OutdatedShow resolvedHide resolved

peps/pep-0796.rst Outdated

		paths.

		A proof-of-concept of this is implemented in the author's branch,
		`rickeylev/feat.relative.pyvenv.home<https://github.com/python/cpython/compare/main...rickeylev:cpython:feat.relative.pyvenv.home>`__.

Copy link

Member

hugovkSep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	`rickeylev/feat.relative.pyvenv.home<https://github.com/python/cpython/compare/main...rickeylev:cpython:feat.relative.pyvenv.home>`__.
	`rickeylev/feat.relative.pyvenv.home
	<https://github.com/python/cpython/compare/main...rickeylev:cpython:feat.relative.pyvenv.home>`__.

Please could you also wrap some of the other long lines to 79 chars?

peps/pep-0796.rst OutdatedShow resolvedHide resolved

ncoghlan reviewed