Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add pagefind search#4247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
miketheman wants to merge1 commit intopython:main
base:main
Choose a base branch
Loading
frommiketheman:pagefind-search

Conversation

miketheman
Copy link
Member

@mikethemanmiketheman commentedJan 31, 2025•
edited by github-actionsbot
Loading

Instead of using sphinx's built-in search which has some challenges in its implementation, as well as the integration with the customized builder and theme, use a different approach.

Pagefind will generate fragments that can be loaded client-side efficiently.

Refs:https://pagefind.app/
Refs:https://pypi.org/project/pagefind/

📚 Documentation preview 📚:https://pep-previews--4247.org.readthedocs.build/

hugovk reacted with hooray emoji
Instead of using sphinx's built-in search which has some challengesin its implementation, as well as the integration with the customizedbuilder and theme, use a different approach.Pagefind will generate fragments that can be loaded client-sideefficiently.Refs:https://pagefind.app/Refs:https://pypi.org/project/pagefind/Signed-off-by: Mike Fiedler <miketheman@gmail.com>
@miketheman
Copy link
MemberAuthor

Definitely needs more styling, and I put it at the top of the sidebar since that made sense to me, but it might be better elsewhere.

Left a TODO - I'm not sure how/when the nodes attributes are getting cleared afterPEPTitle.apply() - something else is removing anything non-classes and I wasn't able to figure it out yet.

But give it a whirl!

@nineteendo
Copy link
Contributor

The search box looks a little big to me, and it displays "Python Enhancement Proposals" instead of the page titles. But it already looks promising.

miketheman reacted with thumbs up emoji

@willingc
Copy link
Contributor

@miketheman I'm not familiar with pagefind. I tried the preview site and it works well. Thank you!

miketheman and hugovk reacted with thumbs up emoji

@miketheman
Copy link
MemberAuthor

Thanks gang!

Definitely needs some styling, and mobile theme integration, since that doesn't appear to work on my phone yet.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner will be requested when the pull request is marked ready for reviewAA-Turner is a code owner

@hugovkhugovkAwaiting requested review from hugovkhugovk will be requested when the pull request is marked ready for reviewhugovk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@miketheman@nineteendo@willingc
[8]ページ先頭
©2009-2025 Movatter.jp