Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

PEP 750: major updates to "Template Strings" based on community feedback#4062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
AA-Turner merged 173 commits intopython:mainfromdavepeck:pep750-post-sprint-update
Oct 22, 2024

Conversation

@davepeck
Copy link
Contributor

@davepeckdavepeck commentedOct 16, 2024
edited by hugovk
Loading

  • Change is either:
    • To a Draft PEP
    • To an Accepted or Final PEP, with Steering Council approval
    • To fix an editorial issue (markup, typo, link, header, etc)
  • PR title prefixed with PEP number (e.g.PEP 123: Summary of changes)

This PR contains substantial updates to PEP 750 based on feedback from the broader Python community, including comments on theofficial PEP Discourse thread and in-person core team feedback at the recent Bellevue, WA, USA sprint.

It has been reviewed by:

Koudai Aono (@koxudaxi) and I were both added as co-authors.


Basic requirements (all PEP Types)

  • Read and followedPEP 1 &PEP 12
  • File created from thelatest PEP template
  • PEP has next available number, & set in filename (pep-NNNN.rst), PR title (PEP 123: <Title of PEP>) andPEP header
  • Title clearly, accurately and concisely describes the content in 79 characters or less
  • Core dev/PEP editor listed asAuthor orSponsor, and formally confirmed their approval
  • Author,Status (Draft),Type andCreated headers filled out correctly
  • PEP-Delegate,Topic,Requires andReplaces headers completed if appropriate
  • Required sections included
    • Abstract (first section)
    • Copyright (last section; exact wording from template required)
  • Code is well-formatted (PEP 7/PEP 8) and is incode blocks, with the right lexer names if non-Python
  • PEP builds with no warnings, pre-commit checks pass and content displays as intended in the rendered HTML
  • Authors/sponsor added to.github/CODEOWNERS for the PEP

Standards Track requirements

  • PEP topicdiscussed in a suitable venue with general agreement that a PEP is appropriate
  • Suggested sections included (unless not applicable)
    • Motivation
    • Rationale
    • Specification
    • Backwards Compatibility
    • Security Implications
    • How to Teach This
    • Reference Implementation
    • Rejected Ideas
    • Open Issues
  • Python-Version set to valid (pre-beta) future Python version, if relevant
  • Any project stated in the PEP as supporting/endorsing/benefiting from the PEP formally confirmed such (not relevant?)
  • Right before or after initial merging,PEP discussion thread created and linked to inDiscussions-To andPost-History (the existing Discourse thread isfound here )

📚 Documentation preview 📚:https://pep-previews--4062.org.readthedocs.build/pep-0750/

davepeckand others added30 commitsSeptember 27, 2024 13:36
Update PEP 750 to use Template and Interpolation classes in a proposal part
Modified the `Interpolation` class definition, changing it from a `Protocol` to a regular class. Updated various instances in the PEP to reflect changes in syntax and terminology, replacing `tag function` with `template function` where appropriate.
davepeckand others added11 commitsOctober 21, 2024 07:58
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Copy link
Member

@AA-TurnerAA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for putting up with me@davepeck! This seems in a good state to merge (I've left a comment ontemplatelib on the thread, but it's non editorial.)

Do you have anything outstanding before merging? We should probably get this in before it hits 200 commits, and anything missed can be covered in a follow up.

Thank you again!

A

davepeck reacted with hooray emoji
@davepeck
Copy link
ContributorAuthor

Thank you for putting up with me@davepeck!

On the contrary, thankyou for putting up with me and my zillion edits! :-)

This seems in a good state to merge (I've left a comment ontemplatelib on the thread, but it's non editorial.)

Yes, at this point, I think we can merge. We'll need another turn of the crank for sure, but it's in a good place for now.

AA-Turner reacted with heart emoji

Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
@AA-TurnerAA-Turner merged commitd3b4ab6 intopython:mainOct 22, 2024
@AA-Turner
Copy link
Member

Thanks@davepeck!

A

ncoghlan pushed a commit to ncoghlan/peps that referenced this pull requestOct 23, 2024
…ack (python#4062)Co-authored-by: Koudai Aono <koxudaxi@gmail.com>Co-authored-by: pauleveritt <paul.everitt@jetbrains.com>Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
gvanrossum pushed a commit to gvanrossum/peps that referenced this pull requestDec 10, 2024
…ack (python#4062)Co-authored-by: Koudai Aono <koxudaxi@gmail.com>Co-authored-by: pauleveritt <paul.everitt@jetbrains.com>Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes

@willingcwillingcwillingc approved these changes

@AA-TurnerAA-TurnerAA-Turner approved these changes

@gvanrossumgvanrossumAwaiting requested review from gvanrossumgvanrossum is a code owner

@lysnikolaoulysnikolaouAwaiting requested review from lysnikolaoulysnikolaou is a code owner

+3 more reviewers

@jimbakerjimbakerjimbaker left review comments

@nineteendonineteendonineteendo left review comments

@InSyncWithFooInSyncWithFooInSyncWithFoo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@davepeck@lysnikolaou@AA-Turner@jimbaker@JelleZijlstra@willingc@nineteendo@InSyncWithFoo@koxudaxi@pauleveritt

[8]ページ先頭

©2009-2025 Movatter.jp