Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.7k
PEP 622: More details on 'marker prefix for lookups' rejected idea#1564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
ncoghlan wants to merge1 commit intopython:masterfromncoghlan:pep-622-propose-rewording-of-some-rejected-ideas
Closed
PEP 622: More details on 'marker prefix for lookups' rejected idea#1564
ncoghlan wants to merge1 commit intopython:masterfromncoghlan:pep-622-propose-rewording-of-some-rejected-ideas
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The "Rejected Ideas" section didn't clearly cover the perceivedbenefits of using a marker prefix on value lookup match patterns.This expands on that section, while still making it clear thatthe listed PEP authors don't agree that the proposal would actuallydeliver the benefits that its proponents believe it would provide.
Member
gvanrossum commentedAug 15, 2020
I'm sorry, I don't want the PEP to be a soapbox for this misguided idea. I'll adopt a few of the clarifications you are proposing at the beginning of the PR, but I don't feel your idea deserves this much airtime in the PEP. |
gvanrossum added a commit that referenced this pull requestAug 15, 2020
mnm678 pushed a commit to mnm678/peps that referenced this pull requestOct 22, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Rejected Ideas" section didn't clearly cover the perceived
benefits of using a marker prefix on value lookup match patterns.
This expands on that section, while still making it clear that
the listed PEP authors don't agree that the proposal would actually
deliver the benefits that its proponents believe it would provide.