Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork3.1k
Fix walrus assignment type propagation across call arguments#20427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
Vaishnavi-KN wants to merge5 commits intopython:masterChoose a base branch fromVaishnavi-KN:fix-walrus-call-args
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+38 −1
Open
Changes from1 commit
Commits
Show all changes
5 commits Select commitHold shift + click to select a range
a1059c3 Fix walrus assignment type propagation in call arguments
Vaishnavi-KN7be65e3 [pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot]870ca9c Clarify intent of walrus assignment inference test
Vaishnavi-KNa9572ff Fix walrus assignment test formatting and naming
Vaishnavi-KNde43aba Update test-data/unit/check-expressions.test
hauntsaninjaFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Fix walrus assignment test formatting and naming
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commita9572ffbcd4be9848cbd43e4bd42e4f3e9da31ff
There are no files selected for viewing
11 changes: 4 additions & 7 deletionstest-data/unit/check-expressions.test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -2539,10 +2539,9 @@ def last_known_value() -> None: | ||
| reveal_type(z) # N: Revealed type is "builtins.str" | ||
| [builtins fixtures/primitives.pyi] | ||
| [case testWalrusAssignmentInCallArguments] | ||
| # Ensure that assignment expressions (:=) in earlier call arguments | ||
| # propagate type information to later arguments in the same call. | ||
| from dataclasses import dataclass | ||
| @@ -2571,6 +2570,4 @@ cases = [ | ||
| ], | ||
| ] | ||
| reveal_type(request_reference) # N: Revealed type is "builtins.str" | ||
Vaishnavi-KN marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.