NotificationsYou must be signed in to change notification settings
Fork3.1k
Star20.1k

Prevent TypeGuardedType leak from`narrow_declared_type` as part of typevar bound#20046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

ilevkivskyi merged 1 commit intopython:masterfromsterliakov:bugfix/gh-20015-typeguard-leak

Oct 12, 2025

Merged

Prevent TypeGuardedType leak from`narrow_declared_type` as part of typevar bound#20046

ilevkivskyi merged 1 commit intopython:masterfromsterliakov:bugfix/gh-20015-typeguard-leak

Oct 12, 2025

Conversation

Copy link

Collaborator

sterliakov commentedOct 10, 2025

Fixes#20015, refs#18895 as a previous example of the same issue. I don't see any similar problems in other branches.

This was too much of a shortcut

0f89c59

sterliakov added the crash label

Oct 10, 2025

Copy link

Contributor

github-actionsbot commentedOct 10, 2025

Diff frommypy_primer, showing the effect of this PR on open source code:

steam.py (https://github.com/Gobot1234/steam.py)- steam/ext/commands/commands.py:285: error: Incompatible types in assignment (expression has type "GroupMixin[Any | None] | Group[Any, [VarArg(Any), KwArg(Any)], Any] | None", variable has type "Self")  [assignment]+ steam/ext/commands/commands.py:285: error: Incompatible types in assignment (expression has type "GroupMixin[Any | None] | Group[CogT, [VarArg(Any), KwArg(Any)], Any] | None", variable has type "Self")  [assignment]scikit-build-core (https://github.com/scikit-build/scikit-build-core)+ src/scikit_build_core/metadata/__init__.py:82: error: Argument 1 has incompatible type "Union[str, dict[str, str]]"; expected "str"  [arg-type]+ src/scikit_build_core/metadata/__init__.py:82: note: Error code "arg-type" not covered by "type: ignore" comment+ src/scikit_build_core/metadata/__init__.py:89: error: Argument 1 has incompatible type "Union[str, list[str], dict[str, str]]"; expected "str"  [arg-type]+ src/scikit_build_core/metadata/__init__.py:89: note: Error code "arg-type" not covered by "type: ignore" comment+ src/scikit_build_core/metadata/__init__.py:94: error: Item "str" of "Union[str, dict[str, str]]" has no attribute "items"  [union-attr]+ src/scikit_build_core/metadata/__init__.py:98: error: Item "str" of "Union[str, dict[str, str]]" has no attribute "items"  [union-attr]+ src/scikit_build_core/metadata/__init__.py:98: note: Error code "union-attr" not covered by "type: ignore" comment+ src/scikit_build_core/metadata/__init__.py:102: error: Left operand of "and" is always true  [redundant-expr]+ src/scikit_build_core/metadata/__init__.py:108: error: Item "str" of "Union[str, list[str], dict[str, str]]" has no attribute "items"  [union-attr]+ src/scikit_build_core/metadata/__init__.py:108: error: Item "list[str]" of "Union[str, list[str], dict[str, str]]" has no attribute "items"  [union-attr]