NotificationsYou must be signed in to change notification settings
Fork3.1k
Star20.1k

[mypyc] Fix broken cancellation handling in async def#19951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JukkaL merged 2 commits intomasterfromfix-gen-exceptions

Sep 29, 2025

Merged

[mypyc] Fix broken cancellation handling in async def#19951

JukkaL merged 2 commits intomasterfromfix-gen-exceptions

Sep 29, 2025

Conversation

Copy link

Collaborator

JukkaL commentedSep 29, 2025

Fix an unexpected undefined attribute error in a generator/async def.
The intent was to explicitly check if an attribute was undefined, but the
attribute read implicitly raisedAttributeError, so the check was never
reached. Fixed by allowing error values to be read without raising
AttributeError.

The error this fixes would look like this (with no line number associated with it):

AttributeError("attribute '__mypyc_temp__12' of 'wait_Condition_gen' undefined")

JukkaL added2 commits

September 29, 2025 12:12

[mypyc] Fix broken exception handling in generators

d6352b5

Fix an unexpected undefined attribute error in a generator/async def.The intent was to explicitly check if an attribute was undefined, but theattribute read implicitly raised `AttributeError`, so the check was neverreached. Fixed by allowing error values to be read.The error would looke like this (with no line number associated with it):```AttributeError("attribute '__mypyc_temp__12' of 'wait_Condition_gen' undefined")```

Add test case

3325a8e