Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork3.1k
[mypyc] Allow defining a single-item free "list" for a native class#19785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
It's quite common to have a class where we almost always have at mosta single allocated instance (per thread). Now these instances can beallocated more quickly, by reusing the memory that was used for themost recently freed instance (a separate memory block is reused foreach thread on free-threaded builds).It's used like this (only the value 1 is supported for now):```from mypy_extensions import mypyc_attr@mypyc_attr(free_list=1)class Foo: ...```This makes a microbenchmark that only allocates and immediatelyfrees simple objects repeatedly around 3.8x faster.It's probably worth extending this to support larger free lists in thefuture.We can later look into enabling this automatically for certain nativeclasses based on profile information.
for more information, seehttps://pre-commit.ci
p-sawicki approved these changesSep 2, 2025
e35e05f intomaster 13 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's quite common to have a class where we almost always have at most a single allocated instance (per thread). Now these instances can be allocated more quickly, by reusing the memory that was used for the most recently freed instance (a separate memory block is reused for each thread on free-threaded builds).
It's used like this (only the value 1 is supported for now):
This makes a microbenchmark that only allocates and immediately frees simple objects repeatedly around 3.8x faster.
It's probably worth extending this to support larger free lists in the future.
We can later look into enabling this automatically for certain native classes based on profile information.