Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork3.1k
Remove --new-type-inference flag#19570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
According tomypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
| self.many_errors_threshold=defaults.MANY_ERRORS_THRESHOLD | ||
| # Disable newexperimentaltype inference algorithm. | ||
| # Disable new type inference algorithm. | ||
| self.old_type_inference=False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Do we still need this one? There are only a couple of use sites remaining, maybe just axe them here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yeah, no, I think we may keep it for a while more (just in case), since it is not a no-op, unlike--new-type-inference.
5b03024 intopython:masterUh oh!
There was an error while loading.Please reload this page.
It was on deprecated almost two years ago (it is on by default).