Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork3k
Add functools.lru_cache plugin support Fixes #16261#19432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
machin0r wants to merge1 commit intopython:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+279 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
9aa3d9f toa4372e8Compare- Add lru_cache callback to functools plugin for type validation - Register callbacks in default plugin for decorator and wrapper calls - Support different lru_cache patterns: @lru_cache, @lru_cache(), @lru_cache(maxsize=N)Fixes issuepython#16261
a4372e8 tod9d5d00CompareDiff frommypy_primer, showing the effect of this PR on open source code: psycopg (https://github.com/psycopg/psycopg)+ psycopg/psycopg/rows.py:136: error: Argument 2 to "_make_nt" has incompatible type "*Generator[bytes | None, None, None]"; expected "bytes" [arg-type]archinstall (https://github.com/archlinux/archinstall)+ archinstall/lib/interactions/general_conf.py:160: error: Argument 1 to "list_available_packages" has incompatible type "tuple[Repository, ...]"; expected "tuple[Repository]" [arg-type]mitmproxy (https://github.com/mitmproxy/mitmproxy)+ mitmproxy/tools/console/common.py:808: error: Argument "request_timestamp" to "format_dns_flow" has incompatible type "float | None"; expected "float" [arg-type]+ mitmproxy/tools/console/common.py:816: error: Argument "error_message" to "format_dns_flow" has incompatible type "str | None"; expected "str" [arg-type]core (https://github.com/home-assistant/core)+ homeassistant/components/xiaomi_aqara/config_flow.py:216: error: Argument 1 to "format_mac" has incompatible type "str | None"; expected "str" [arg-type]+ homeassistant/components/mqtt_room/sensor.py:199: error: Argument 1 to "_slugify_upper" has incompatible type "Any | None"; expected "str" [arg-type]+ homeassistant/components/esphome/manager.py:468: error: Argument 1 to "format_mac" has incompatible type "str | None"; expected "str" [arg-type]+ homeassistant/components/esphome/light.py:182: error: Argument 1 to "_filter_color_modes" has incompatible type "tuple[Any, ...]"; expected "list[Any]" [arg-type]+ homeassistant/components/esphome/light.py:191: error: Argument 1 to "_filter_color_modes" has incompatible type "tuple[Any, ...]"; expected "list[Any]" [arg-type]+ homeassistant/components/esphome/light.py:202: error: Argument 1 to "_filter_color_modes" has incompatible type "tuple[Any, ...]"; expected "list[Any]" [arg-type]+ homeassistant/components/esphome/light.py:211: error: Argument 1 to "_filter_color_modes" has incompatible type "tuple[Any, ...]"; expected "list[Any]" [arg-type]+ homeassistant/components/esphome/light.py:212: error: Argument 1 to "_filter_color_modes" has incompatible type "tuple[Any, ...]"; expected "list[Any]" [arg-type]+ homeassistant/components/esphome/light.py:217: error: Argument 1 to "_filter_color_modes" has incompatible type "tuple[Any, ...]"; expected "list[Any]" [arg-type]+ homeassistant/components/esphome/light.py:229: error: Argument 1 to "_filter_color_modes" has incompatible type "tuple[Any, ...]"; expected "list[Any]" [arg-type]+ homeassistant/components/esphome/light.py:246: error: Argument 1 to "_filter_color_modes" has incompatible type "tuple[Any, ...]"; expected "list[Any]" [arg-type]+ homeassistant/components/esphome/light.py:251: error: Argument 1 to "_filter_color_modes" has incompatible type "tuple[Any, ...]"; expected "list[Any]" [arg-type]+ homeassistant/components/esphome/light.py:265: error: Argument 1 to "_filter_color_modes" has incompatible type "tuple[Any, ...]"; expected "list[Any]" [arg-type]+ homeassistant/components/esphome/light.py:346: error: Argument 1 to "_filter_color_modes" has incompatible type "tuple[Any, ...]"; expected "list[Any]" [arg-type]+ homeassistant/components/esphome/config_flow.py:541: error: Argument 1 to "format_mac" has incompatible type "str | None"; expected "str" [arg-type]+ homeassistant/components/esphome/config_flow.py:591: error: Argument 1 to "format_mac" has incompatible type "str | None"; expected "str" [arg-type]schemathesis (https://github.com/schemathesis/schemathesis)+ src/schemathesis/specs/openapi/stateful/__init__.py:127: error: Argument 2 to "make_response_filter" has incompatible type "tuple[Any, ...]"; expected "Iterator[str]" [arg-type]+ src/schemathesis/specs/openapi/stateful/__init__.py:127: note: "tuple" is missing following "Iterator" protocol member:+ src/schemathesis/specs/openapi/stateful/__init__.py:127: note: __next__ibis (https://github.com/ibis-project/ibis)+ ibis/backends/tests/test_temporal.py:2227: error: Argument "exclude" to "_get_backend_names" has incompatible type "tuple[str, str]"; expected "tuple[str]" [arg-type]+ ibis/backends/tests/test_temporal.py:2245: error: Argument "exclude" to "_get_backend_names" has incompatible type "tuple[str, str, str, str, str, str]"; expected "tuple[str]" [arg-type] |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for
functools.lru_cachedecorator,Fixes#16261Description
Problem: Functions decorated with
@lru_cachelose their original type signatures, preventing mypy from validating function calls properly.Solution:
functools_lru_cache_callbackto preserve function signatures for@lru_cachelru_cache_wrapper_call_callbackto validate calls to cached functionsDefaultPluginfor both decorator creation and wrapper callslru_cachepatternsSupported patterns:
@lru_cache- bare decorator@lru_cache()- empty parentheses@lru_cache(maxsize=128)- parametersExample
Before:
Files changed:
mypy/plugins/functools.py- Implementationmypy/plugins/default.py- Plugin registrationtest-data/unit/check-functools.test- Test casestest-data/unit/lib-stub/functools.pyi- Type stub updates