Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork3k
Add basic support for template strings (PEP 750)#19333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Conversation
Uh oh!
There was an error while loading.Please reload this page.
This comment has been minimized.
This comment has been minimized.
According tomypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice, thanks for working on this!
Modify the AST directly feels a little strange to me. I wonder if it's worth just adding a mypy AST node and handling it in checkexpr, like we do for say DictExpr?
Thanks for taking a look! Yeah, I was hoping to find a less hacky approach. I like the sound of your suggestion |
Refs#19329