Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork3.1k
Avoid spurious non-overlapping eq error with metaclass with__eq__#19220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Currently, doing an `==` on a `type[Foo]` where `Foo` has a metaclassthat defines `__eq__` will spurious produce a non-overlapping equalityerror, because `custom_special_method`, a helper used in the check,does not consider the `TypeType` case.Fix that.
Contributor
Diff frommypy_primer, showing the effect of this PR on open source code: antidote (https://github.com/Finistere/antidote): 1.32x slower (69.4s -> 91.5s in single noisy sample)janus (https://github.com/aio-libs/janus): 1.63x faster (10.8s -> 6.6s in single noisy sample)AutoSplit (https://github.com/Toufool/AutoSplit): 1.05x faster (111.7s -> 106.3s in single noisy sample)mypy (https://github.com/python/mypy): 1.06x slower (108.7s -> 115.2s in single noisy sample)discord.py (https://github.com/Rapptz/discord.py): 1.09x slower (266.6s -> 290.9s in single noisy sample) |
ilevkivskyi approved these changesJun 4, 2025
Member
ilevkivskyi left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks!
(and it is great to have you back :-))
f295bb8 intomaster 19 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Currently, doing an
==on atype[Foo]whereFoohas a metaclassthat defines
__eq__will spuriously produce a non-overlapping equalityerror, because
custom_special_method, a helper used in the check,does not consider the
TypeTypecase.Fix that.