Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix nondeterministic type checking by making join between TypeType and TypeVar commute#19149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JukkaL merged 1 commit intopython:masterfromhauntsaninja:joincommtyptyptypvar
May 27, 2025

Conversation

@hauntsaninja
Copy link
Collaborator

Fixes#18125

Unhandled cases indefault seem fairly dangerous

@hauntsaninjahauntsaninja changed the titleFix commutativity of join between TypeType and TypeVarFix nondeterministic type checking by making join between TypeType and TypeVar commuteMay 26, 2025
@github-actions
Copy link
Contributor

According tomypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

Copy link
Collaborator

@A5rocksA5rocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

At some point I was trying to get some basic property testing setup which could eliminate this class of bugs, but it ended up too complicated :(

This makes sense though.

hauntsaninja reacted with thumbs up emoji
@JukkaLJukkaL merged commit27d118b intopython:masterMay 27, 2025
18 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@A5rocksA5rocksA5rocks approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Type error randomly raised when using a decorator and atype: ignore comment

3 participants

@hauntsaninja@A5rocks@JukkaL
[8]ページ先頭
©2009-2025 Movatter.jp