Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork3.1k
[mypyc] Fix incref/decref on free-threaded builds#19127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Fix C compile errors on free-threaded builds. We can't (easily) accessthe reference count value directly, so always use the C API functionswhen on a free-threaded build.
| #ifndefPy_GIL_DISABLED | ||
| // The *_NO_IMM operations below perform refcount manipulation for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you adjust this comment to mention something like "this optimization cannot be performed with free threaded mode so we fallback to just calling the normal decref.
750a579 intomasterUh oh!
There was an error while loading.Please reload this page.
Fix C compile errors on free-threaded builds. We can't (easily) access the reference count value directly, so always use the C API functions when on a free-threaded build.
Work onmypyc/mypyc#1038.