Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Remove last unreachable block from mypyc code#19086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
sterliakov wants to merge1 commit intopython:master
base:master
Choose a base branch
Loading
fromsterliakov:bugfix/st-remove-unreachable

Conversation

sterliakov
Copy link
Collaborator

@sterliakovsterliakov commentedMay 13, 2025
edited
Loading

Supplements#19050. The old version did certainly contain unreachable code, as otherwise that branch would have crashed, there is notype_args attribute. This block was introduced in#17027 - probably as a future-proof expansion to generic primitive operations, but it makes no sense now, this logic can be added back should it become necessary. cc@JukkaL as the original author

Copy link
Collaborator

@A5rocksA5rocks left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I actually ran into this when making mypy check unreachable code and replaced the unreachable branch with anassert False so I'm very sure this is right!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@A5rocksA5rocksA5rocks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@sterliakov@A5rocks

[8]ページ先頭

©2009-2025 Movatter.jp