Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork3.1k
Admit that Final variables are never redefined#19083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Admit that Final variables are never redefined#19083
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This comment has been minimized.
This comment has been minimized.
hauntsaninja left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice, thank you!
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
According tomypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
0b65f21 intopython:masterUh oh!
There was an error while loading.Please reload this page.
Fixes#19080. There is no point applying our heuristics if the variable is declared Final - it is not reassigned anywhere.