Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.9k
support Callable / callable Protocols in suggest decorator unwarpping#19072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This comment has been minimized.
This comment has been minimized.
| @@ -659,7 +671,7 @@ def extract_from_decorator(self, node: Decorator) -> FuncDef | None: | |||
| for ct in typ.items: | |||
| if not ( | |||
| len(ct.arg_types) == 1 | |||
| andisinstance(ct.arg_types[0], TypeVarType) | |||
| and_arg_accepts_function(get_proper_type(ct.arg_types[0])) | |||
| and ct.arg_types[0] == ct.ret_type | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can this becomeis_same_type to allow aliases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I assume you mean the== line?
probably! but that'd be a separate issue / patch I would imagine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes, sorry, misclicked - I meant the == line of course.
| @@ -659,7 +671,7 @@ def extract_from_decorator(self, node: Decorator) -> FuncDef | None: | |||
| for ct in typ.items: | |||
| if not ( | |||
| len(ct.arg_types) == 1 | |||
| andisinstance(ct.arg_types[0], TypeVarType) | |||
| and_arg_accepts_function(get_proper_type(ct.arg_types[0])) | |||
| and ct.arg_types[0] == ct.ret_type | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes, sorry, misclicked - I meant the == line of course.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Stanislav Terliakov <50529348+sterliakov@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think batchingis_same_type here would be appropriate, but don't mind deferring that to a separate PR if you'd prefer. LG, thanks!
According tomypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Resolves#18940
while I feel like just accepting any identity function would be good enough I expanded the check to explicitly allow Callables and Protocol callables