Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork3.1k
Fixdmypy suggest interaction with__new__#18966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Fixdmypy suggest interaction with__new__#18966
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…have `cls` argument
This comment has been minimized.
This comment has been minimized.
A5rocks left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This makes sense, is this pattern elsewhere and if so would it make sense to extract it to an@property? (I guess people wouldn't know to use it.)
sterliakov commentedApr 25, 2025
Turns out there are a few places doing such check, so reusing sounds reasonable. Added a doc comment for the attribute with usage guidance. |
This comment has been minimized.
This comment has been minimized.
sterliakov commentedMay 1, 2025
@JukkaL if you're preparing the next release, can this PR sneak in? It only fixes a crash in |
52dedc3 todcbb0d2CompareAccording tomypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
ae778cc intopython:masterUh oh!
There was an error while loading.Please reload this page.
Fixes#18964.
__new__is special - it hasis_staticset insemanal.py, but still has firstclsargument. This PR tellsdmypy suggestabout that.