Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

stubtest: better checking of runtime args with dunder names#18756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hauntsaninja merged 2 commits intopython:masterfromhauntsaninja:stubrelax
Mar 7, 2025

Conversation

@hauntsaninja
Copy link
Collaborator

@hauntsaninjahauntsaninja commentedMar 5, 2025•
edited
Loading

Fixes#15302,fixes#14560. Linking#18343

jorenham and Avasam reacted with rocket emoji
@jorenham
Copy link
Contributor

jorenham commentedMar 5, 2025•
edited
Loading

I just ran it on the numpy stubs innumpy/numtype, and when I remove the allowlist entry that I mentioned in#15302 (comment), it passes 🎉.

I'm not sure if it's relevant here, but if I don't remove that allowlist entry, stubtest doesn't report it as unused.

edit:

I published the code tohttps://github.com/numpy/numtype/tree/mypy-18756. To repro, runuv run tool/stubtest.py, and uncomment line 37 in the.mypyignore allowlist (https://github.com/numpy/numtype/blob/0c64f1e0cc3d17312a60a1c3f883367f9f9d39cb/.mypyignore#L37)

jorenham added a commit to numpy/numtype that referenced this pull requestMar 5, 2025
@hauntsaninjahauntsaninja merged commita067d84 intopython:masterMar 7, 2025
12 checks passed
@hauntsaninjahauntsaninja deleted the stubrelax branchMarch 7, 2025 00:16
@hauntsaninja
Copy link
CollaboratorAuthor

Thanks for checking, will look into the unused allowlist thing too...

jorenham reacted with thumbs up emoji

hauntsaninja added a commit to hauntsaninja/numtype that referenced this pull requestMar 7, 2025
cc@jorenham I was looking intopython/mypy#18756 (comment)It looks like the pre-release version of mypy crashes (for some reason related to property changes, will investigate). Crash logs are emitted to stderr and process exits with exit code 2.This code does correctly chain the exit code, but swallows stderr.
jorenham pushed a commit to numpy/numtype that referenced this pull requestMar 7, 2025
cc@jorenham I was looking intopython/mypy#18756 (comment)It looks like the pre-release version of mypy crashes (for some reason related to property changes, will investigate). Crash logs are emitted to stderr and process exits with exit code 2.This code does correctly chain the exit code, but swallows stderr.
@jorenhamjorenham mentioned this pull requestMay 11, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

stubtest: Recognize __ as indicating positional-only arg at runtime stubtest: False-positives with parameter name mangling outside of classes

2 participants

@hauntsaninja@jorenham
[8]ページ先頭
©2009-2025 Movatter.jp