Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork3.1k
Fix regression for user config files#18656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This comment has been minimized.
This comment has been minimized.
mypy/config_parser.py Outdated
| current_dir=parent_dir | ||
| forconfig_fileindefaults.USER_CONFIG_FILES: | ||
| forconfig_fileinmap(os.path.expanduser,defaults.USER_CONFIG_FILES): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is there any reason to expand here and not early indefaults.py?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Fair point, if the original code had done that the bug would never have happened :-)
Diff frommypy_primer, showing the effect of this PR on open source code: django-stubs (https://github.com/typeddjango/django-stubs): 1.97x faster (49.0s -> 24.9s in a single noisy sample) |
44f82ef intopython:masterUh oh!
There was an error while loading.Please reload this page.
Fixespython#18650Slightly annoying to add a test for since it would clutter up user homedirectory
Fixespython#18650Slightly annoying to add a test for since it would clutter up user homedirectory
Fixespython#18650Slightly annoying to add a test for since it would clutter up user homedirectory
Fixes#18650
Slightly annoying to add a test for since it would clutter up user home directory