Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork3.1k
Fix literal context for ternary expressions (for real)#18545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
ilevkivskyi merged 1 commit intopython:masterfromilevkivskyi:fix-literal-ternary-for-realJan 27, 2025
Merged
Fix literal context for ternary expressions (for real)#18545
ilevkivskyi merged 1 commit intopython:masterfromilevkivskyi:fix-literal-ternary-for-realJan 27, 2025
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Contributor
According tomypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
16e19f8 intopython:master 18 checks passed
Uh oh!
There was an error while loading.Please reload this page.
5 tasks
wesleywright pushed a commit that referenced this pull requestJan 27, 2025
I am not waiting for review as the fix is obvious. The only annoyingthing is that we had an exact test as in the repro but it passedaccidentally because we use builtins fixtures.
x612skm pushed a commit to x612skm/mypy-dev that referenced this pull requestFeb 24, 2025
I am not waiting for review as the fix is obvious. The only annoyingthing is that we had an exact test as in the repro but it passedaccidentally because we use builtins fixtures.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not waiting for review as the fix is obvious. The only annoying thing is that we had an exact test as in the repro but it passed accidentally because we use builtins fixtures.