NotificationsYou must be signed in to change notification settings
Fork3.1k
Star20.1k

[stubgen] Preserve dataclass_transform decorator#18418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

hauntsaninja merged 2 commits intopython:masterfromcdce8p:stubgen-preserve-dataclass_transform

Jan 7, 2025

Merged

[stubgen] Preserve dataclass_transform decorator#18418

hauntsaninja merged 2 commits intopython:masterfromcdce8p:stubgen-preserve-dataclass_transform

Jan 7, 2025

Conversation

Copy link

Collaborator

cdce8p commentedJan 5, 2025

Ref:#18081

[stubgen] Preserve dataclass_transform decorator

8bd9d50

cdce8p added topic-stubgen topic-dataclass-transformPEP 681 labels

Jan 5, 2025

cdce8p requested a review fromhamdanal

January 5, 2025 19:19

hamdanal reviewed

Jan 5, 2025

View reviewed changes

Copy link

Collaborator

hamdanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks. Could you add a non-semanal test?

Copy link

CollaboratorAuthor

Not sure that would be helpful here. All cases fordataclass_transform depend on the semantic analysis. Without it, the derived classes wouldn't be recognized as dataclass. I.e. the tests would all fail AFAICT.

Copy link

Collaborator

hamdanal commentedJan 5, 2025

I still think it is useful to have a test, just to be sure we do not generate a broken syntax or something. You can leave a comment in the test saying that it is not expected to work as good as with semantic analysis.