Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork3.1k
DisallowTypeVar constraints parameterized by type variables#18186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
hauntsaninja merged 8 commits intopython:masterfrombrianschubert:conformance-typevar-constraint-genericDec 1, 2024
Merged
DisallowTypeVar constraints parameterized by type variables#18186
hauntsaninja merged 8 commits intopython:masterfrombrianschubert:conformance-typevar-constraint-genericDec 1, 2024
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
CollaboratorAuthor
brianschubert commentedNov 25, 2024
Conformance results diff for this PR ( diff --git a/conformance/results/mypy/generics_basic.toml b/conformance/results/mypy/generics_basic.tomlindex 00c8244..b15fe50 100644--- a/conformance/results/mypy/generics_basic.toml+++ b/conformance/results/mypy/generics_basic.toml@@ -6,6 +6,7 @@ output = """ generics_basic.py:40: error: Value of type variable "AnyStr" of "concat" cannot be "Sequence[object]" [type-var] generics_basic.py:41: error: Value of type variable "AnyStr" of "concat" cannot be "Sequence[object]" [type-var] generics_basic.py:49: error: Type variable must have at least two constrained types [misc]+generics_basic.py:55: error: TypeVar constraint type cannot be parametrized by type variables [misc] generics_basic.py:69: error: Value of type variable "AnyStr" of "concat" cannot be "Sequence[object]" [type-var] generics_basic.py:121: error: Duplicate type variables in Generic[...] or Protocol[...] [misc] generics_basic.py:157: error: Invalid index type "int" for "MyMap1[str, int]"; expected type "str" [index]@@ -15,7 +16,6 @@ generics_basic.py:191: error: Type variable "generics_basic.T" is unbound [vali generics_basic.py:191: note: (Hint: Use "Generic[T]" or "Protocol[T]" base class to bind "T" inside a class) generics_basic.py:191: note: (Hint: Use "T" in function signature to bind "T" inside a function) """-conformance_automated = "Fail"+conformance_automated = "Pass" errors_diff = """-Line 55: Expected 1 errors """diff --git a/conformance/results/mypy/version.toml b/conformance/results/mypy/version.tomlindex 51d97b4..59e0dd2 100644--- a/conformance/results/mypy/version.toml+++ b/conformance/results/mypy/version.toml@@ -1,2 +1,2 @@-version = "mypy 1.14.0+dev.499adaed8adbded1a180e30d071438fef81779ec"-test_duration = 2.4+version = "mypy 1.14.0+dev.841096633fe6255acb7840e4a7b0fce975b8ca24"+test_duration = 4.4 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
c467949 to8cc1aeeCompare This comment has been minimized.
This comment has been minimized.
This comment was marked as outdated.
This comment was marked as outdated.
This comment has been minimized.
This comment has been minimized.
Uh oh!
There was an error while loading.Please reload this page.
Not exactly a semanal error, but could be and adds useful context
Contributor
According tomypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
hauntsaninja approved these changesDec 1, 2024
3268a7a intopython:master 19 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emit an error forthis test case from the conformance tests: