Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork3.1k
FixOR pattern structural matching exhaustiveness#18119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
JukkaL merged 2 commits intopython:masterfromshenyih0ng:fix/or-pattern-match-exhaustivenessNov 11, 2024
Merged
FixOR pattern structural matching exhaustiveness#18119
JukkaL merged 2 commits intopython:masterfromshenyih0ng:fix/or-pattern-match-exhaustivenessNov 11, 2024
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
4cd8a8c to2c6a179Compare This comment has been minimized.
This comment has been minimized.
2c6a179 toff90fbbCompareContributor
According tomypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
brianschubert approved these changesNov 10, 2024
Collaborator
brianschubert left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice! LGTM!
f067db4 intopython:master 19 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Fixes#18108
This PR fixes the issue of missing value comparisons in a
MatchStmtdue toOrPatternincorrectly narrowing down the type of the subject.