Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork3.1k
[mypyc] Replace deprecated _PyDict_GetItemStringWithError#17930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[mypyc] Replace deprecated _PyDict_GetItemStringWithError#17930
Uh oh!
There was an error while loading.Please reload this page.
Conversation
hauntsaninja left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Does this return a strong reference when the old one returned a borrowed reference?
JukkaL left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks, looks good to me.
Fixesmypyc/mypyc#1078Introduced in#17930See the first commit to see the bug (wrong condition)---------Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
Fixesmypyc/mypyc#1078Introduced in#17930See the first commit to see the bug (wrong condition)---------Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
Uh oh!
There was an error while loading.Please reload this page.
_PyDict_GetItemStringWithErrorwas deprecated for Python 3.14 inpython/cpython#119855.Use
PyDict_GetItemStringRefinstead. It was added in 3.13 but is available viapythoncapi_compat.h.https://docs.python.org/3/c-api/dict.html#c.PyDict_GetItemStringRef