Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork3.1k
Fix crash when passing too many type arguments to generic base class accepting single ParamSpec#17770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Contributor
According tomypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
hauntsaninja approved these changesSep 21, 2024
Collaborator
hauntsaninja left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice, thank you for the very clear writeup!
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#17765
The offender for this crash appears to be this snippet:
mypy/mypy/semanal.py
Lines 5905 to 5910 in72c413d
This branch triggers when applying type args to a type that is generic with respect to a single
ParamSpec. It allows double brackets to be omitted when providing a parameter specification by wrapping all of the provided type arguments into a single parameter specification argument (i.e. equatingFoo[int, int]toFoo[[int, int]]). This wrapping occursunless:Any(e.g.Foo[Any])ParamSpec(e.g.Foo[[int, int]])The problem occurs when multiple type arguments provided and at least one of them is a bracketed parameter specification, as in
Foo[[int, int], str].Per the rules above, since there is more than 1 type argument, mypy attempts to wrap the arguments into a single parameter specification. This results in the attempted creation of a
Parametersinstance that contains anotherParametersinstance, which triggers this assert insideParameters.__init__:mypy/mypy/types.py
Line 1634 in72c413d
I think a reasonable solution is to forgo wrapping the type arguments into a single
Parametersifany of the provided type arguments are aParameters/ParamSpecType. That is, don't transformFoo[A1, A2, ...]toFoo[[A1, A2, ...]]if any ofA1, A2, ...are a parameter specification.This change brings the crash case inline with mypy's current behavior for a similar case:
Before this change:
After this change: