Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork3.1k
Fix --install-types masking failure details#17485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
It seems that if the mypy cache dir wasn't created, this code would do an exit, preventing the actual errors from being printed. So I've removed the exit.
This comment has been minimized.
This comment has been minimized.
wyattscarpenter commentedAug 20, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I should add that I've confirmed this works usinghttps://github.com/tk-woven/mypy-install-types-mre I've installed my patch branch as a git source in pip, and it works on the mre. In contrast, when I installed the current mypy master ( I've been using the mypy from my patch branch as a daily driver and haven't noticed any other problems resulting from this change (although theoretically there could be some obscure edge case I just don't run into). |
wyattscarpenter commentedSep 16, 2024
As a note to myself: if this pr is accepted, or the issue is otherwise fixed, I can get rid of the workaround I added to this other project:https://github.com/databricks/databricks-sql-python/blob/main/.github/workflows/code-quality-checks.yml#L164 |
Uh oh!
There was an error while loading.Please reload this page.
for more information, seehttps://pre-commit.ci
According tomypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
7b61945 intopython:masterUh oh!
There was an error while loading.Please reload this page.
v1.14.1 is the current version, andpython/mypy#17485 has the "upnext" label, so 1.15 should do
seepython/mypy#17485 orpython/mypy#10768 for more information
v1.14.1 is the current version, andpython/mypy#17485 has the "upnext" label, so 1.15 should do
seepython/mypy#17485 orpython/mypy#10768 for more information
v1.14.1 is the current version, andpython/mypy#17485 has the "upnext" label, so 1.15 should doSigned-off-by: wyattscarpenter <wyattscarpenter@gmail.com>
seepython/mypy#17485 orpython/mypy#10768 for more informationSigned-off-by: wyattscarpenter <wyattscarpenter@gmail.com>
v1.14.1 is the current version, andpython/mypy#17485 has the "upnext" label, so 1.15 should doSigned-off-by: wyattscarpenter <wyattscarpenter@gmail.com>
seepython/mypy#17485 orpython/mypy#10768 for more informationSigned-off-by: wyattscarpenter <wyattscarpenter@gmail.com>
It seems that: if the mypy cache dir wasn't created, this code would do an exit, preventing the actual errors from being printed. So I've removed the exit. More information is available at the issue I claim this fixes.
Fixes#10768