Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork3.1k
Some cleanup in partial plugin#17423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Contributor
Diff frommypy_primer, showing the effect of this PR on open source code: jax (https://github.com/google/jax)- jax/_src/nn/functions.py:585: error: Argument 1 to "custom_jvp" has incompatible type "Callable[[Array | Any | Any | Any | bool | int | float | complex, int | tuple[int, ...] | None, Array | Any | Any | Any | bool | int | float | complex | None, Array | Any | Any | Any | bool | int | float | complex | None], Array]"; expected "Callable[..., Never]" [arg-type]- jax/_src/scipy/special.py:1059: error: Argument 1 to "custom_jvp" has incompatible type "Callable[[Array | Any | Any | Any | bool | int | float | complex, int], Array]"; expected "Callable[..., Never]" [arg-type]- jax/experimental/rnn.py:245: error: Argument 1 to "custom_vjp" has incompatible type "Callable[[Array, Array, Array, Array, Array, int, int, int, float, bool, str | Precision | tuple[str, str] | tuple[Precision, Precision] | None], tuple[Array, Array, Array]]"; expected "Callable[..., Never]" [arg-type]+ jax/_src/scipy/stats/norm.py:161: error: Redundant cast to "Array" [redundant-cast]- jax/_src/cudnn/fused_attention_stablehlo.py:1000: error: Need type annotation for "output" [var-annotated]- jax/experimental/pallas/ops/tpu/flash_attention.py:1579: error: Need type annotation for "res" [var-annotated]pwndbg (https://github.com/pwndbg/pwndbg)- pwndbg/gdblib/events.py:160: error: Need type annotation for "before_prompt" [var-annotated] |
hauntsaninja approved these changesJun 22, 2024
Collaborator
hauntsaninja left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks, I was just looking into this, had pretty similar diff. There's one more bug in my implementation, I will merge this and add the additional fix
MemberAuthor
ilevkivskyi commentedJun 22, 2024
Yes, I also have#17424, andmaybe one more. |
hauntsaninja added a commit that referenced this pull requestJul 1, 2024
- Fixes another crash case / type inference in that case- Fix a false positive when calling the partially applied function withkwargs- TypeTraverse / comment / daemon test follow up ilevkivskyi mentionedon the original PRSee also#17423
hauntsaninja added a commit that referenced this pull requestJul 1, 2024
- Fixes another crash case / type inference in that case- Fix a false positive when calling the partially applied function withkwargs- TypeTraverse / comment / daemon test follow up ilevkivskyi mentionedon the original PRSee also#17423
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#17405
Apart from fixing the crash I fix two obvious bugs I noticed while making this PR.
cc@hauntsaninja