Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork3.1k
Fix self-referential upper bound in new-style type variables#17407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This comment has been minimized.
This comment has been minimized.
JukkaL left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for fixing this! I couldn't remember how this all worked and was pretty confused when I briefly looked into this myself.
According tomypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Fixes#17347
This copies old-style
TypeVarlogic 1:1 (I know it is ugly, but I don't think there is anything better now). Also while I am touching this code, I am removingthird_passargument (third pass is not a thing for ~5 years now).