Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork3.1k
Speed up finding function type variables#16562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This used to be a significant performance bottleneck, especially intests.Merge logic from two type visitors into a single visitor. Also don'trely on generic type query visitors but implement logic for all typesdirectle, since it will be faster.
Contributor
According tomypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
CollaboratorAuthor
JukkaL commentedDec 28, 2023
Going to merge this now, to avoid this getting stale. If anybody wants to review this afterwards, I'm happy to address feedback in a follow-up PR. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge two visitors into a single visitor that is a bit more optimized than the old visitors.
This speeds ups tests, in particular --
mypy/test/testcheck.pyis about 4% faster andmypy/test/testpythoneval.pyis about 3% faster.Also self-check is about 1% faster, both interpreted and compiled.
This adds more code, but the new code is largely boilerplate, so the difficulty of maintenance seems roughly the same.