Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Call dynamic class hook on generic classes#16052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sobolevn merged 1 commit intopython:masterfromflaeppe:fix/issue-8359
Sep 19, 2023

Conversation

@flaeppe
Copy link

Fixes:#8359

CC@sobolevn

get_dynamic_class_hook() will now additionally be called for generic classes with parameters. e.g.

y=SomeGenericClass[type, ...].method()

Copy link
Member

@sobolevnsobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM! Thanks!

Let's wait for one more review, because we are clearly very opinioned about this feature :)

@flaeppe
Copy link
Author

Let's wait for one more review, because we are clearly very opinioned about this feature :)

Yes indeed, we're quite biased here

@github-actions
Copy link
Contributor

According tomypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@sobolevnsobolevn merged commitba978f4 intopython:masterSep 19, 2023
@sobolevn
Copy link
Member

Congrats@flaeppe on your first mypy contribution :)
It would be awesome if you continue!

flaeppe reacted with hooray emoji

@flaeppeflaeppe deleted the fix/issue-8359 branchSeptember 19, 2023 08:03
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@sobolevnsobolevnsobolevn approved these changes

@ilevkivskyiilevkivskyiilevkivskyi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

get_dynamic_class_hook() not invoked on generic types

3 participants

@flaeppe@sobolevn@ilevkivskyi
[8]ページ先頭
©2009-2025 Movatter.jp