May 3, 2023 · Apr 24, 2023 · Apr 24, 2023 · Apr 24, 2023 · Apr 24, 2023 · Apr 24, 2023
diff --git a/test-data/unit/check-optional.test b/test-data/unit/check-optional.test
 x: Optional[str] = "x"

 def cannot_narrow_top_level() -> None:
    reveal_type(x)  # N: Revealed type is "Union[builtins.str, None]"
    global x
    if x is None:
        x = "a"
    def nested() -> str:
        # This should perhaps not be narrowed, since the nested function could outlive
        # the outer function, and since other functions could also assign to x, but
        # this seems like a minor issue.
        return x
    nested()

 [case testNarrowedVariableInNestedFunctionMore1]
 from typing import Optional, overload
Original file line number	Diff line number	Diff line change
Expand Up		@@ -1084,7 +1084,15 @@ def cannot_narrow_if_reassigned(x: Optional[str]) -> None:
		x: Optional[str] = "x"

		def cannot_narrow_top_level() -> None:
Copy link Member ilevkivskyiApr 27, 2023 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. The actual narrowing is missing here. Until#2008 is fixed this would be optional despite r.h.s. So you need to write x:Optional[str]ifxisNone:x="x" here as well. Copy link CollaboratorAuthor JukkaLMay 3, 2023 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Yeah this was an incomplete test case.
		reveal_type(x) # N: Revealed type is "Union[builtins.str, None]"
		global x
		if x is None:
		x = "a"
		def nested() -> str:
		# This should perhaps not be narrowed, since the nested function could outlive
		# the outer function, and since other functions could also assign to x, but
		# this seems like a minor issue.
		return x
		nested()

		[case testNarrowedVariableInNestedFunctionMore1]
		from typing import Optional, overload
Expand Down