Mar 24, 2023 · Mar 23, 2023 · Mar 24, 2023 · Mar 24, 2023 · Mar 24, 2023 · Mar 24, 2023
diff --git a/mypy/stubtest.py b/mypy/stubtest.py
    for message in _verify_static_class_methods(stub, runtime, static_runtime, object_path):
        yield Error(object_path, "is inconsistent, " + message, stub, runtime)

    # TODO: Should call _verify_final_method here, but it crashes stubtest: see #14950

    signature = safe_inspect_signature(runtime)
    if not signature:
        return
        yield f"is inconsistent, runtime {item_type} is abstract but stub is not"


 def _verify_final_method(stub: nodes.FuncDef, runtime: Any, static_runtime: MaybeMissing[Any]) -> Iterator[str]:
 def _verify_final_method(
    stub: nodes.FuncDef, runtime: Any, static_runtime: MaybeMissing[Any]
 ) -> Iterator[str]:
    if stub.is_final:
        return
    if (
        getattr(runtime, "__final__", False)
        or (
            static_runtime is not MISSING
            and getattr(static_runtime, "__final__", False)
        )
    if getattr(runtime, "__final__", False) or (
        static_runtime is not MISSING and getattr(static_runtime, "__final__", False)
    ):
        yield "is decorated with @final at runtime, but not in the stub"

diff --git a/mypy/test/teststubtest.py b/mypy/test/teststubtest.py
            """,
            error="K.foo",
        )
        # This test wouldn't pass,
        # because the runtime can't set __final__ on instances of builtins.property,
        # so stubtest has non way of knowing that the runtime was decorated with @final:
        #
        # yield Case(
        #     stub="""
        #     class K2:
        #         @property
        #         def foo(self) -> int: ...
        #     """,
        #     runtime="""
        #     class K2:
        #         @final
        #         @property
        #         def foo(self): return 42
        #     """,
        #     error="K2.foo",
        # )
        yield Case(
            stub="""
            class L:
Original file line number	Diff line number	Diff line change
Expand Up		@@ -1065,6 +1065,8 @@ def verify_overloadedfuncdef(
		for message in _verify_static_class_methods(stub, runtime, static_runtime, object_path):
		yield Error(object_path, "is inconsistent, " + message, stub, runtime)

		# TODO: Should call _verify_final_method here, but it crashes stubtest: see #14950

		signature = safe_inspect_signature(runtime)
		if not signature:
		return
Expand DownExpand Up		@@ -1154,15 +1156,13 @@ def _verify_abstract_status(stub: nodes.FuncDef, runtime: Any) -> Iterator[str]:
		yield f"is inconsistent, runtime {item_type} is abstract but stub is not"


		def _verify_final_method(stub: nodes.FuncDef, runtime: Any, static_runtime: MaybeMissing[Any]) -> Iterator[str]:
		def _verify_final_method(
		stub: nodes.FuncDef, runtime: Any, static_runtime: MaybeMissing[Any]
		) -> Iterator[str]:
		if stub.is_final:
		return
		if (
		getattr(runtime, "__final__", False)
		or (
		static_runtime is not MISSING
		and getattr(static_runtime, "__final__", False)
		)
		if getattr(runtime, "__final__", False) or (
		static_runtime is not MISSING and getattr(static_runtime, "__final__", False)
		):
		yield "is decorated with @final at runtime, but not in the stub"

Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -1364,6 +1364,24 @@ def foo(self): return 42
		""",
		error="K.foo",
		)
		# This test wouldn't pass,
		# because the runtime can't set __final__ on instances of builtins.property,
		# so stubtest has non way of knowing that the runtime was decorated with @final:
		#
		# yield Case(
		# stub="""
		# class K2:
		# @property
		# def foo(self) -> int: ...
		# """,
		# runtime="""
		# class K2:
		# @final
		# @property
		# def foo(self): return 42
		# """,
		# error="K2.foo",
		# )
		yield Case(
		stub="""
		class L:
Expand Down