NotificationsYou must be signed in to change notification settings
Fork3.1k
Star20.1k

Stubtest: verify stub methods or properties are decorated with`@final` if they are decorated with`@final` at runtime#14951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

sobolevn merged 7 commits intopython:masterfromAlexWaygood:stubtest-final-methods

Mar 24, 2023

Merged

Stubtest: verify stub methods or properties are decorated with`@final` if they are decorated with`@final` at runtime#14951

sobolevn merged 7 commits intopython:masterfromAlexWaygood:stubtest-final-methods

Mar 24, 2023

Conversation

Copy link

Member

AlexWaygood commentedMar 23, 2023

This implements most of#14924. The only thing itdoesn't implement is verification for overloaded methods decorated with@final -- I tried working on that, but hit#14950.

Stubtest: verify stub methods or properties are decorated with `@fina…

3d4c8ef

…l` if they are decorated with `@final` at runtime

AlexWaygood requested review fromhauntsaninja andsobolevn

March 23, 2023 23:23

AlexWaygood added the topic-stubtest label

Mar 23, 2023

sobolevn reviewed

Mar 24, 2023

View reviewed changes

Copy link

Member

sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for taking this up! 👍

mypy/test/teststubtest.pyShow resolvedHide resolved

Copy link

Member

sobolevn commentedMar 24, 2023

I also thing that overloads can easily be ignored at this stage. Because I don't think many users have final overloads in their runtime source code + separate stubs :)