Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork3.1k
Fix narrowing union types that include Self with isinstance (Fixes #14912).#14923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Fix narrowing union types that include Self with isinstance (Fixes #14912).#14923
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…thon#14921).The special case of bound type variables was not handled in function `covers_at_runtime` of module `subtypes`. So I added it and defined the test case `testNarrowSelfType`.
According tomypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
tyralla commentedMar 19, 2023
The fixed issues' number was wrong. I corrected it in the title and the initial comment of this pull request. Unfortunately, the initial commit's message is also wrong in this regard and needs modification before merging. |
hauntsaninja left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you!
Uh oh!
There was an error while loading.Please reload this page.
Fix narrowing union types that include Self with isinstance (Fixes#14912).
The special case of bound type variables was not handled in function
covers_at_runtimeof modulesubtypes. So I added it and defined the test casetestNarrowSelfType.