NotificationsYou must be signed in to change notification settings
Fork3.1k
Star20.1k

Reduce size of JSON data in Mypy cache#14808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JelleZijlstra merged 1 commit intopython:masterfromdosisod:minify-json-cache

Mar 1, 2023

Merged

Reduce size of JSON data in Mypy cache#14808

JelleZijlstra merged 1 commit intopython:masterfromdosisod:minify-json-cache

Mar 1, 2023

Conversation

Copy link

Contributor

dosisod commentedMar 1, 2023

By default, Python outputs spaces after commas and colons when dumping JSON data. This is normally fine, but when exporting large amounts of JSON (such as cache info) it is more space efficient to export JSON without whitespaces. To do this, simply passseparators=(",", ":") tojson.dumps().

Although the space savings aren't massive, they do reduce the size of the cache folder by a couple of megabytes:

Method	Size
Current	31.2MB
This PR	29.3MB

For comparison, the size of the cache folder with the--sqlite-cache option is about 27.5MB.

Reduce size of JSON data in Mypy cache:

cfef2c8

By default, Python outputs spaces after commas and colons when dumping JSONdata. This is normally fine, but when exporting large amounts of JSON (such ascache info) it is more space efficient to export JSON without whitespaces. Todo this, simply pass `separators=(",", ":")` to `json.dumps()`.Although the space savings aren't massive, they do reduce the size of the cachefolder by a couple of megabytes:| Method  | Size   ||---------|--------|| Current | 31.2MB || This PR | 29.3MB |For comparison, the size of the cache folder with the `--sqlite-cache` optionis about 27.5MB.