NotificationsYou must be signed in to change notification settings
Fork3.1k
Star20.1k

More helpful error for missing self#14386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

hauntsaninja merged 3 commits intopython:masterfromhauntsaninja:self-error

Jan 3, 2023

Merged

More helpful error for missing self#14386

hauntsaninja merged 3 commits intopython:masterfromhauntsaninja:self-error

Jan 3, 2023

Conversation

Copy link

Collaborator

hauntsaninja commentedJan 3, 2023

Fixes#14385

More helpful error for missing self

a9c8060

Fixespython#14385

hauntsaninja mentioned this pull request

Jan 3, 2023

Method must have at least one argument [misc]#14385

Closed

lint

e8031a9

AlexWaygood approved these changes

Jan 3, 2023

View reviewed changes

Copy link

Member

AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice idea!

JelleZijlstra reviewed

Jan 3, 2023

View reviewed changes

mypy/semanal.py OutdatedShow resolvedHide resolved

quotes

de1a691

JelleZijlstra approved these changes

Jan 3, 2023

View reviewed changes

Copy link

Contributor

github-actionsbot commentedJan 3, 2023

Diff frommypy_primer, showing the effect of this PR on open source code:

prefect (https://github.com/PrefectHQ/prefect)- src/prefect/orion/orchestration/global_policy.py:45: error: Method must have at least one argument  [misc]+ src/prefect/orion/orchestration/global_policy.py:45: error: Method must have at least one argument. Did you forget the "self" argument?  [misc]- src/prefect/orion/orchestration/global_policy.py:62: error: Method must have at least one argument  [misc]+ src/prefect/orion/orchestration/global_policy.py:62: error: Method must have at least one argument. Did you forget the "self" argument?  [misc]- src/prefect/orion/orchestration/core_policy.py:41: error: Method must have at least one argument  [misc]+ src/prefect/orion/orchestration/core_policy.py:41: error: Method must have at least one argument. Did you forget the "self" argument?  [misc]- src/prefect/orion/orchestration/core_policy.py:58: error: Method must have at least one argument  [misc]+ src/prefect/orion/orchestration/core_policy.py:58: error: Method must have at least one argument. Did you forget the "self" argument?  [misc]- src/prefect/orion/orchestration/core_policy.py:76: error: Method must have at least one argument  [misc]+ src/prefect/orion/orchestration/core_policy.py:76: error: Method must have at least one argument. Did you forget the "self" argument?  [misc]- src/prefect/orion/orchestration/core_policy.py:81: error: Method must have at least one argument  [misc]+ src/prefect/orion/orchestration/core_policy.py:81: error: Method must have at least one argument. Did you forget the "self" argument?  [misc]