Previously we only applied argument types before type checking, but it looks like we can totally do this in semantic analyzer. I also enable variable annotated astype (or equivalentlyType[Any]), this use case was mentioned in the comments.

This PR also accidentally fixes two additional bugs, one related to type variables with values vs walrus operator, another one for type variables with values vs self types. I include test cases for those as well.

ilevkivskyi added2 commits

November 18, 2022 20:20

Allow function arguments as base classes

1561ed8

Improve test

5cfbfb4

ilevkivskyi requested review fromJelleZijlstra,JukkaL andhauntsaninja

November 18, 2022 20:26

This comment has been minimized.

Copy link

MemberAuthor

ilevkivskyi commentedNov 18, 2022

Thehomeassistant errors are caused by exposing an existing bug in walrus. On master this test

[case testNarrowOnSelfInGeneric]# flags: --strict-optionalfrom typing import Generic, TypeVar, OptionalT = TypeVar("T", int, str)class C(Generic[T]):    x: Optional[T]    def meth(self) -> Optional[T]:        if (y := self.x) is not None:            return reveal_type(y)        return None

reveals typeAny. But with this PR it becomes optional, so it is still wrong. I will first try to figure out what is going on.

Copy link

MemberAuthor

ilevkivskyi commentedNov 18, 2022

OK, I have a fix for the walrus bug, since it is an obvious bug, I am going to just add it to this PR.

Fix (+ unrelated bug with a test)

49e9ab3

This comment has been minimized.

Copy link

MemberAuthor

ilevkivskyi commentedNov 19, 2022

Looking again atmypy_primer it looks like this PR accidental fixes another bug related to type vars with values, this type for self types. I am going to include a regression for that one as well.

Add test case for another accidentally fixed bug

1d8c773

Copy link

Contributor

github-actionsbot commentedNov 19, 2022

Diff frommypy_primer, showing the effect of this PR on open source code:

artigraph (https://github.com/artigraph/artigraph)+ tests/arti/producers/test_producer.py:679: error: Unused "type: ignore" comment+ tests/arti/producers/test_producer.py:680: error: Unused "type: ignore" commentTanjun (https://github.com/FasterSpeeding/Tanjun)- tanjun/dependencies/reloaders.py:566: error: Cannot determine type of "real_path"  [has-type]- tanjun/dependencies/reloaders.py:567: error: Cannot determine type of "time"  [has-type]- tanjun/dependencies/reloaders.py:578: error: Cannot determine type of "info"  [has-type]- tanjun/dependencies/reloaders.py:579: error: Cannot determine type of "time"  [has-type]- tanjun/dependencies/reloaders.py:599: error: Cannot determine type of "path"  [has-type]- tanjun/dependencies/reloaders.py:600: error: Cannot determine type of "tracked_value"  [has-type]- tanjun/dependencies/reloaders.py:609: error: Cannot determine type of "path"  [has-type]- tanjun/dependencies/reloaders.py:609: error: Cannot determine type of "path_info"  [has-type]- tanjun/commands/menu.py:580: error: Incompatible return value type (got "MenuCommand[_MenuCommandCallbackSigT, _MenuTypeT]", expected "Self")  [return-value]mypy (https://github.com/python/mypy)+ mypy/stubtest.py:357: error: Unused "type: ignore[valid-type]" commentcloud-init (https://github.com/canonical/cloud-init)+ cloudinit/templater.py:44: error: Unused "type: ignore" comment